Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚒ Fix release docs javadocs & archive actions #6089

Merged
merged 10 commits into from
Jun 22, 2024
Merged

⚒ Fix release docs javadocs & archive actions #6089

merged 10 commits into from
Jun 22, 2024

Conversation

AyhamAl-Ali
Copy link
Member

@AyhamAl-Ali AyhamAl-Ali commented Oct 2, 2023 •
edited
Loading

Description

In this PR:

  • Fixed javadocs not generating in skript release docs and archiving due to missing output path (was added to another task instead)
  • Removed releaseJavadoc task in gradle in favor of java's default (customized) task javadoc (@Pikachu920 please double check this, not sure why it was done like this)

Target Minecraft Versions: any
Requirements: none
Related Issues: none

@AyhamAl-Ali AyhamAl-Ali added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. documentation Related to Skript's official documentation. github related Issues or Pull requests that affect the GitHub organization/repositories labels Oct 2, 2023
@AyhamAl-Ali AyhamAl-Ali added the hacktoberfest-accepted Marks a PR as accepted for Hacktoberfest label Oct 5, 2023
Pikachu920
Pikachu920 requested changes Oct 9, 2023
View reviewed changes
build.gradle Outdated Show resolved Hide resolved
Pikachu920
Pikachu920 approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@Pikachu920 Pikachu920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

props for finding the issues!

@AyhamAl-Ali AyhamAl-Ali marked this pull request as draft October 12, 2023 21:07
@AyhamAl-Ali AyhamAl-Ali mentioned this pull request Jan 13, 2024
Merged
Base automatically changed from dev/patch to master June 1, 2024 19:38
@APickledWalrus APickledWalrus changed the base branch from master to dev/patch June 16, 2024 19:42
@Pikachu920 Pikachu920 marked this pull request as ready for review June 20, 2024 21:47
@APickledWalrus APickledWalrus merged commit 975b952 into dev/patch Jun 22, 2024
6 checks passed
@APickledWalrus APickledWalrus deleted the fix/docs-release-push branch June 22, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@APickledWalrus APickledWalrus APickledWalrus approved these changes

@Pikachu920 Pikachu920 Pikachu920 approved these changes

@Moderocky Moderocky Moderocky approved these changes

@sovdeeth sovdeeth sovdeeth approved these changes

Assignees
No one assigned
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. documentation Related to Skript's official documentation. github related Issues or Pull requests that affect the GitHub organization/repositories hacktoberfest-accepted Marks a PR as accepted for Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AyhamAl-Ali @sovdeeth @Moderocky @Pikachu920 @APickledWalrus